system_modes icon indicating copy to clipboard operation
system_modes copied to clipboard

Seperate CI for focal and jammy. Added humble distro to workflow

Open norro opened this issue 3 years ago • 2 comments

Configures two (almost identical) workflows

  • foxy and galactic to be built on Ubuntu focal
  • humble and rolling to be built on Ubuntu jammy

Had to exclude include-order from cpplint, as it is expecting different orders on foxy+galactic resp. humble+rolling and I don't want to branch just for this.

Signed-off-by: Arne Nordmann [email protected]

norro avatar Jun 05 '22 09:06 norro

Codecov Report

Merging #93 (ffcc8de) into master (d62e24c) will increase coverage by 2.67%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   32.72%   35.39%   +2.67%     
==========================================
  Files          14       14              
  Lines        1048     1226     +178     
  Branches      754      807      +53     
==========================================
+ Hits          343      434      +91     
- Misses        114      210      +96     
+ Partials      591      582       -9     
Impacted Files Coverage Δ
system_modes/include/system_modes/mode.hpp 100.00% <ø> (ø)
...ystem_modes/include/system_modes/mode_handling.hpp 100.00% <ø> (ø)
...stem_modes/include/system_modes/mode_inference.hpp 100.00% <ø> (ø)
system_modes/include/system_modes/mode_monitor.hpp 100.00% <ø> (ø)
system_modes/src/system_modes/mode_monitor.cpp 25.17% <0.00%> (-1.81%) :arrow_down:
system_modes/src/system_modes/mode_manager.cpp 17.10% <0.00%> (-1.32%) :arrow_down:
system_modes/include/system_modes/mode_impl.hpp 83.33% <0.00%> (+1.85%) :arrow_up:
system_modes/src/system_modes/mode_inference.cpp 41.16% <0.00%> (+3.56%) :arrow_up:
system_modes/src/system_modes/mode_handling.cpp 33.33% <0.00%> (+5.74%) :arrow_up:
system_modes/src/system_modes/mode.cpp 62.66% <0.00%> (+6.92%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 682ecb7...ffcc8de. Read the comment docs.

codecov[bot] avatar Jun 05 '22 09:06 codecov[bot]

If I see it correctly, the only difference between the two Action workflow files is the Linux distribution. Two files are not necessary. The ROS distributions and the corresponding Linux distributions can be also specified as a list of pairs, cf. https://github.com/boschresearch/fmi_adapter/blob/master/.github/workflows/build_and_test.yml#L16

ralph-lange avatar Jun 08 '22 07:06 ralph-lange