Streaming exposes an unsafe destroy

[treeowl]

foo, bar :: Stream (Of Char) [] Char
foo = lift ['a','b'] >>= lift . (: [])
bar = lift (['a','b'] >>= (: []))

By the monad transformer laws, foo = bar, but in fact destroy foo P.show P.show P.show /= destroy bar P.show P.show P.show. I blame destroy. Indeed, Streaming.Internal.destroyExposed carefully documents the dangers and necessary restrictions, but destroy is (presumably accidentally) implemented using identical code:

destroy
  :: (Functor f, Monad m) =>
     Stream f m r -> (f b -> b) -> (m b -> b) -> (r -> b) -> b
destroy stream0 construct effect done = loop stream0 where
  loop stream = case stream of
    Return r -> done r
    Effect m  -> effect (liftM loop m)
    Step fs  -> construct (fmap loop fs)

destroyExposed stream0 construct effect done = loop stream0 where
  loop stream = case stream of
    Return r -> done r
    Effect m  -> effect (liftM loop m)
    Step fs  -> construct (fmap loop fs)

The most obvious fix is to simply define

destroy = destroyExposed . unexposed

but there may be a slightly more efficient way.

[treeowl]

I think the cleaned up version probably looks like this:

destroy
  :: (Functor f, Monad m) =>
     Stream f m r -> (f b -> b) -> (m b -> b) -> (r -> b) -> b
destroy s construct effect done = effect (loop s) where
  loop stream = case stream of
    Step fs -> return (construct (fmap (effect . loop) fs))
    Effect m -> m >>= loop
    Return r -> return (done r)

[treeowl]

FYI, it appears this bug was introduced in e2ab123d446428f668527935c70e302c9612a1bd. I believe my implementation likely does a better job of fusing code than the previous working version did, but I haven't tried benchmarking that.

[andrewthad]

This is no longer the official repo for streaming. Please continue discussion of this issue here.