Michael Gregorius
Michael Gregorius
@Rossmaxx, with regards to the functionality everything is working for me. However, it would be nice if there was an indication of what element is currently selected so that the...
I think this is a general artifact of global scaling especially under X11. I have also experienced this with a scaling of 1.25. It's somewhat better under Wayland.
@zapashcanon From the attached screenshot I take that you are running a resolution of 2880 × 1800? I assume that Qt checks the resolution and DPI value and then decides...
I was requested as a reviewer but I am wondering if this PR is already ready for review? The title still says "WIP" and not all checkmarks are checked yet.
@sakertooth, @Veratil, I agree. It was the quickest way to add methods to `sampleFrame`. However, this is now fixed with commit bd408529e24.
@Veratil, thanks for the (as always) thorough review! I have applied all you suggestions with commit 925a58c35db and came to love the "Add suggestion to batch" feature while doing so....
> As a class, `sampleFrame` should be renamed `SampleFrame` to follow the UpperCamelCase convention. @messmerd, I'd like to do this as a last step when it is clear that this...
I have a local branch ready where `sampleFrame` is renamed to `SampleFrame` and where it's moved into its own file.
My plan is to await @DomClark's review, merge this PR if everything is OK and then to do the renaming and the moving in a separate PR that I will...
@messmerd, do you mean the casts in `LadspaEffect::processAudioBuffer` and `PlayHandle::buffer`? Or are there any other ones?