WebAudioPlugins icon indicating copy to clipboard operation
WebAudioPlugins copied to clipboard

RFC: Don't require plugins to have `main.js`

Open vitaliy-bobrov opened this issue 6 years ago • 2 comments

The restriction to name plugin entry file name as main.js won't work for most cases, different environments would use different entries, ex. es5 / es2019 / ts versions.

vitaliy-bobrov avatar Nov 08 '19 12:11 vitaliy-bobrov

Indeed. For the V2 of the SDK this would be a good addition to be able to specify the name of the main js file in the main.json descriptor.

micbuffa avatar Feb 13 '20 10:02 micbuffa

I thought this is not the case? In fact, it looks like the SDK, when calls .load() actually refers to the name of the class given in main.json. See here: https://github.com/micbuffa/WebAudioPlugins/blob/master/sdk/WebAudioSDK.js#L289

khoin avatar Mar 26 '20 07:03 khoin