custom-plugin-lib icon indicating copy to clipboard operation
custom-plugin-lib copied to clipboard
verified publisher icon mia-platform

Remove required env variables

Open davidebianchi opened this issue 2 years ago • 1 comments

The feauture or bug you are proposing

Here are set the default variables required by the cpl https://github.com/mia-platform/custom-plugin-lib/blob/b7dd0ea65303b51d909f706991a9efb3b5899e51/index.js#L43-L95

For example, there is also the MICROSERVICE_GATEWAY_SERVICE_NAME env var, also if microservice-gateway does not exists in project.

For my point of view, it's ok which are configurable but this env should not be required. Also, the MICROSERVICE_GATEWAY_SERVICE_NAME should be optional and enable/disable the pre/post decorator function (raising an error).

davidebianchi avatar Jul 04 '23 09:07 davidebianchi

you mean to remove the required for the MICROSERVICE_GATEWAY_SERVICE_NAME or the other env as well? Also, you wish to have a default value hardcoded in the repo or just disable certain feature if variables aren't set?

fredmaggiowski avatar Jul 04 '23 15:07 fredmaggiowski