Michael Henriksen
Michael Henriksen
Should maybe change some text here (no longer opt-in): https://github.com/kubevirt/containerized-data-importer/blob/main/doc/waitforfirstconsumer-storage-handling.md#configuration---opt-in
/lgtm /approve
/hold we must keep k8s deps pinned
Looks like KubeVirt only imports the [pkg/clone](https://github.com/kubevirt/kubevirt/tree/main/vendor/kubevirt.io/containerized-data-importer) package. Maybe make that module?
> > Looks like KubeVirt only imports the [pkg/clone](https://github.com/kubevirt/kubevirt/tree/main/vendor/kubevirt.io/containerized-data-importer) package. Maybe make that module? > > Does it change anything in dependency tree/analysis when that is a module? If yes...
@maya-r I don't think a user should have to manually update the stored version. Why can't cdi-operator do the equivalent of "option 2" as described here: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#upgrade-existing-objects-to-a-new-stored-version FYI: I'm not...
> The reason that I want the user to do a manual operation is that we have two kinds of CRDs: > > 1. datavolume/cdiconfig/... and other CRDs created by...
@maya-r, finally got around to reviewing/testing this. I wanted to test upgrading from 1.19 to this version and what a journey it was. Is that something you tried? Here's what...
/lgtm /approve
/lgtm /approve