docker-apachewebdav icon indicating copy to clipboard operation
docker-apachewebdav copied to clipboard

Two pull requests from original project not used

Open mgutt opened this issue 4 years ago • 1 comments

As described, our project which is based on https://github.com/BytemarkHosting/docker-webdav includes the following changes:

  • https://github.com/BytemarkHosting/docker-webdav/pull/20
  • https://github.com/BytemarkHosting/docker-webdav/pull/28
  • https://github.com/noodlefighter/docker-webdav/pull/1
  • https://github.com/BytemarkHosting/docker-webdav/pull/11
  • https://github.com/BytemarkHosting/docker-webdav/pull/21
  • https://github.com/BytemarkHosting/docker-webdav/pull/23
  • https://github.com/BytemarkHosting/docker-webdav/pull/25

By that those are missing:

  • https://github.com/BytemarkHosting/docker-webdav/pull/15 I skipped this as it creates dependencies to traefik (proxy) and I'm note sure which benefits it results
  • (https://github.com/BytemarkHosting/docker-webdav/pull/6 I skipped this as our project uses httpd:2.4.43-alpine which includes Alpine 3.12.0. A more recent version like 2.4.46 uses Alpine 3.13.x which is incompatible as it misses an important package. Finally I'm note sure if https://github.com/docker-library/httpd/issues/115 is still valid with 2.4.43 / 3.12. Needs more feedback.

So except of the last item, I think all relevant pull requests are now included.

mgutt avatar Aug 11 '21 08:08 mgutt

Hey, I just found that repo because I searched for a simple way to deploy a WebDAV server for multiple users.

I see that you didn't include the PR https://github.com/BytemarkHosting/docker-webdav/pull/15 because it depends on traefik. I look at it and I don't see any specific traefik entries beside in the docker-compose file under labels.

There are only there so the Traefik reverse proxy knows what to do with the container. These changes are not Traefik specific in any way.

fenpaws avatar Mar 11 '22 10:03 fenpaws