mglaman
Upstream: Extension System, Part IV: Properly register all installed extensions/namespaces in container
Does this sound like the same issue?
$ ./bin/drupal-check -d docroot/core/modules/hal
36/36 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ---------------------------------------------------------------------------------------------------------------------------------
Line src/HalServiceProvider.php
------ ---------------------------------------------------------------------------------------------------------------------------------
Class Drupal\hal\HalServiceProvider was not found while trying to analyse it - autoloading is probably not configured properly.
------ ---------------------------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------
Line tests/src/Unit/NormalizerDenormalizeExceptionsUnitTestBase.php
------ -------------------------------------------------------------------------
21 Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase:
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Tests\PhpunitCompatibilityTrait::createMock() instead.
------ -------------------------------------------------------------------------
[ERROR] Found 2 errors
And then with ZERO changes to anything, I've run it again;
$ ./bin/drupal-check -d docroot/core/modules/hal
36/36 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ -------------------------------------------------------------------------
Line tests/src/Unit/NormalizerDenormalizeExceptionsUnitTestBase.php
------ -------------------------------------------------------------------------
21 Call to deprecated method getMock() of class Drupal\Tests\UnitTestCase:
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Tests\PhpunitCompatibilityTrait::createMock() instead.
------ -------------------------------------------------------------------------
[ERROR] Found 1 error
We see this same issue in lots of places unfortunately. It's only ever on the very first try though, so it affects our CI more than locally. To reproduce you need to;
rm -rf vendor/mglaman
composer install
...and then run the check again.
🤔 Kind of. But this issue is more to track / try to improve Drupal core's autoloading system which makes this extension easier to maintain
Hmmmmm is it worth my opening a new issue, or just track/ assist with the core issue? We found that although the patch seemed to address the issue ... it completely broke Drush (with an autoload error).