Add support to restricted collection item size
This is a real quick re-apply of some code that I used to add support for collections with a specified min/max occurs as well as a primitive type that has its own restrictions.
Codecov Report
Attention: Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.
Project coverage is 94.37%. Comparing base (
e835215) to head (d0d01a7). Report is 34 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| XmlSchemaClassGenerator/TypeModel.cs | 96.70% | 1 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 94.21% 94.37% +0.16%
==========================================
Files 21 21
Lines 3148 3238 +90
Branches 496 507 +11
==========================================
+ Hits 2966 3056 +90
Misses 118 118
Partials 64 64
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Is this ready to merge?
Functionally ready but could use a flag\check to only generate the simple types when they are required/useful. Current example if the user doesn't want data-annotation, I can't think of a reason to use the simple types.
I also want to auto generate implicit casts but that seems to be a bit to much to put in this PR
Functionally ready but could use a flag\check to only generate the simple types when they are required/useful. Current example if the user doesn't want data-annotation, I can't think of a reason to use the simple types.
So perhaps they should be enabled by default if DataAnnotations are enabled and disabled by default if DataAnnotations are disabled?
I also want to auto generate implicit casts but that seems to be a bit to much to put in this PR
That would be great. Let me know when you want to merge.