Mees Fix
Mees Fix
@bhilbert4 here are my thoughts: 1. I agree with the indenting, I recall in multiple files we have in the package we just repeat lines like this: ``` from jwql.module_name...
@bhilbert4 thats okay, the binary operator was giving me issues too. As for number 3 I found this: https://stackoverflow.com/questions/18998010/flake8-complains-on-boolean-comparison-in-filter-clause Solution is to add `#noqa` to that line.
This has been a long time coming @bhilbert4 @mengesser, merging.
@bourque if you know anyone with some more JS experience could take a look at this. It was a little buggy before my changes. The tables don't display properly when...
@mperrin --- @BradleySappington pretty much touched all of the points here. Although the version changes are incremental and sometimes seem unnecessary it will save us time in the long run....
> Current status: API documentation and view have been cleaned up such that they are all working and reference in-flight data. Checking the views in the browser show that everything...
@BradleySappington looks like you have some conflicts here. Would you be able to resolve them? I am going to start my review now!
@BradleySappington if the notes I made on the commented out functions are to update the flags in the database, I would like to check this out as well. The web...
> * [x] Line 246 of monitor_views should be module = 'msata_monitor' rather than module = 'msata_monitor.py' Nailed it, good catch @bhilbert4
@penaguerrero THANK YOU FOR WRITING TESTS!