wd icon indicating copy to clipboard operation
wd copied to clipboard

Fix "wd list" error if path contains symbol ":"

Open ShangjinTang opened this issue 3 years ago • 1 comments

Fix the warp points not complete issue:

create warp point

~/demo:cpp % wd add democpp
 * Warp point added

original

~/demo:cpp % wd list
 * All warp points:
democpp  ->  ~/demo

after this fix

~/demo:cpp % wd list
 * All warp points:
democpp  ->  ~/demo:cpp

ShangjinTang avatar Jul 12 '22 03:07 ShangjinTang

Hi there! Thanks for the PR

Could you please add a test to this function for your fix? Just to check the output isn't incorrectly truncated

alpha-tango-kilo avatar Jul 12 '22 12:07 alpha-tango-kilo

I proposed a test implementation in https://github.com/ShangjinTang/wd/pull/1 - don't know if this is good enough - let me know, if I need to change anything.

tomterl avatar Oct 06 '22 12:10 tomterl

Thanks for adding this, I'll consolidate the patches and merge this later

alpha-tango-kilo avatar Oct 06 '22 12:10 alpha-tango-kilo