Khoward height max vertical velocity
Addresses #GitHubissuenum
This is a plugin to find the height at which a maximum occurs. This is for the Maximum vertical velocity workflow. We need to know the height at which the maximum occurs for our meteorologists to help them identify lee waves.
Testing:
- [x] Ran tests and they passed OK
- [x] Added new tests for the new feature(s)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.32%. Comparing base (
84a8944) to head (9227556). Report is 18 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2012 +/- ##
==========================================
- Coverage 98.39% 98.32% -0.08%
==========================================
Files 124 129 +5
Lines 12212 12592 +380
==========================================
+ Hits 12016 12381 +365
- Misses 196 211 +15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Acceptance test data is here: https://github.com/metoppv/improver_test_data/pull/51
I have a notebook within information on the acceptance test data that can be accessed through /data/users/khoward/EPP_data/max_vertical_velocity/vertical_velocity.ipynb
I have changed the acceptance tests data to reduce the size of it - but wasn't able to recreate the kgo @mspelman07 can you do this? It was doing weird errors when I tried. I've put pushed up a latest version of the data without the kgo, but if you need the old data it can be found here: /data/users/khoward/EPP_data/max_vertical_velocity/old_data
I have update the acceptance test data including regenerating the kgo. I found the errors were being caused by a mislabelled file in the acceptance test data. I've updated this but as I can't push to this PR I have created a new PR: https://github.com/metoppv/improver/pull/2020 to replace this one.
As such I'm closing this PR as it has been superseeded.