core
core copied to clipboard
Fix Docker image build cache dependencies
…uilds
The Docker Hub workflow had several issues preventing images from building correctly when there was no local cache:
-
Each
docker buildx bakecall was independent, so dependent images (dev->deps, runtime->dev, cli->runtime) couldn't find their base images -
Syntax error in manifest creation loop (missing opening quote)
-
Deprecated
::set-outputGitHub Actions syntax
Changes:
- Add docker-bake.hcl with proper target dependencies using
contextsto allow BuildX to resolve image dependencies within a single build - Update sub_platform() to use single bake command instead of 4 separate calls
- Add Dockerfile.dockerignore files for BuildKit's per-dockerfile ignore support
- Fix syntax error in docker-hub.yml manifest creation
- Update to modern $GITHUB_OUTPUT syntax
- Add depends_on to docker-compose.yml for proper service ordering
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixes #(issue_no)
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Documentation update
Checklist:
- [ ] I have performed a self-review of my own code.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have made corresponding changes to the documentation.
- [ ] My changes generate no new warnings.
- [ ] I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
- [ ] I have tested the tests implicated (if any) by my own code and they pass (
make testorctest -VV -R <test-name>). - [ ] If my change is significant or breaking, I have passed all tests with
./docker-compose.sh test &> outputand attached the output. - [ ] I have tested my code with
OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK. - [ ] I have tested my code with
OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output. - [ ] I have tested with
Helgrindin case my code works with threading. - [ ] I have run
make clang-formatin order to format my code and my code follows the style guidelines.
If you are unclear about any of the above checks, have a look at our documentation here.