dav-server-rs icon indicating copy to clipboard operation
dav-server-rs copied to clipboard

Upgrade http library to 1.0, including some dependcies and hyper

Open themasch opened this issue 2 years ago • 4 comments

While testing to get dav-server-rs working with a recent axum release, I encountered some problems because axum is using [email protected], while dav-server-rs was still based on [email protected].

Since the 1.0 release of http brings some stability & BC promises, I figured it might be work updating to the new release to this library is ready to be used with recent releases of all the frameworks building on http.

I did not touch the warp and actix example yet, that would be the next step.

I fixed up the hyper examples (the latest hyper release dropped some QoL features which bloats the example a bit) and ran the litmus test suite. Results where as documented in the README.

themasch avatar Jan 04 '24 15:01 themasch

Okay, seems like neither warp nor actix currently support http 1.0 so I am not really sure how to fix those examples without depending on two versions of http, hyper, and some other things.

themasch avatar Jan 06 '24 15:01 themasch

Take https://github.com/miquels/webdav-handler-rs/pull/33 as an example if you are interesting. I've just found that there is a fork of miquels/webdav-handler-rs.

without depending on two versions of http, hyper, and some other things.

I don't think it's possible. http v0.4 must be used for warp / actix internally.

ArcticLampyrid avatar Jan 12 '24 11:01 ArcticLampyrid

@ArcticLampyrid to be honest, I'd be in favour of dropping the examples of warp/actix until they updated to http v1.0 over adding shim code to bridge between 1.0 and 0.4. But luckily thats not my call to make ;)

Having two somewhat actively maintained forks of whats effectively the same librarys makes things even more complicated. Looking at the history of both forks, the seem to diverge after 8972c98baeb05286185370b14b8bb205dec46d7c, in May 2021 (v 0.2.0).

I will have another (longer) look at your PR over the weekend and see if I can adapt that to this PR. Thank you for that!

themasch avatar Jan 12 '24 12:01 themasch

seems like neither warp nor actix currently support http 1.0

To aide tracking these dependencies...

Warp issue to upgrade (via use of hyper 1.0) is here I think:

https://github.com/seanmonstar/warp/issues/1088

Actix issue is here:

https://github.com/actix/actix-web/pull/3208

linuxtim avatar Feb 18 '24 10:02 linuxtim

closing this in favour of #28 as that includes this, and also fixes the examples. Thanks @quasiyoke!

themasch avatar Jun 17 '24 08:06 themasch