subgraphs icon indicating copy to clipboard operation
subgraphs copied to clipboard

Abracadabra All: Snapshots with 0 values

Open melotik opened this issue 3 years ago • 8 comments

Abracadabra snapshots have 0 values when there is no activity. To fix this we need to ensure that no cumulative values are set to 0 on creation, they should be initialized with the actual cumulative value.

See image: image

melotik avatar Oct 28 '22 19:10 melotik

Abracadabra Avalanche marketDailySnapshots do not have any data in the rate fields, regardless of which market.

https://api.thegraph.com/subgraphs/name/messari/abracadabra-money-avalanche/graphql?query=%7B%0A++markets+%7B%0A++%09dailySnapshots+%28first%3A+1%29+%7B%0A++++++id%0A++++%09rates+%7B%0A++++++%09id%0A++++%09%7D%0A++++%7D%0A++++hourlySnapshots+%28first%3A+1%29+%7B%0A++++++rates+%7B%0A++++++++id%0A++++++%7D%0A++++%7D%0A++%7D%0A%7D

MichaelC1999 avatar Dec 07 '22 15:12 MichaelC1999

@dmelotik Is this still an issue?

bye43 avatar Jan 04 '23 18:01 bye43

I added into the fix for #957

melotik avatar Jan 04 '23 23:01 melotik

This does not seem to be a subgraph issue anymore in the latest version of the subgraph: https://subgraphs.messari.io/subgraph?endpoint=https%3A%2F%2Fapi.thegraph.com%2Fsubgraphs%2Fid%2FQmRde24xjTq8NGP4QUX9sUVzFzD3YZ5WF8SV7X8QxQc4YM&tab=pool&poolId=0x4eaed76c3a388f4a841e9c765560bbe7b3e4b3a0&view=marketDailySnapshots-totalDepositBalanceUSD

@yulesa on your DA, with this endpoint (https://thegraph.com/hosted-service/subgraph/messari/abracadabra-money-ethereum) is it still an issue?

melotik avatar Jan 30 '23 20:01 melotik

It is: query image

yulesa avatar Feb 02 '23 17:02 yulesa

https://subgraphs.messari.io/subgraph?endpoint=https%3A//api.thegraph.com/subgraphs/id/QmRde24xjTq8NGP4QUX9sUVzFzD3YZ5WF8SV7X8QxQc4YM&tab=pool&poolId=0x003d5a75d284824af736df51933be522de9eed0f

yulesa avatar Feb 02 '23 17:02 yulesa

Aha, good catch @yulesa it looks like the price of sOHM is not correct. Looking into this

melotik avatar Feb 02 '23 21:02 melotik

The pricing is broken for the sOHM pool, but given it is so small (< $20k tvl in the pool) we are deprioritizing this.

If this is an issue in the future we will re-open discussion and make an appropriate fix.

melotik avatar Feb 22 '23 02:02 melotik