pushprom icon indicating copy to clipboard operation
pushprom copied to clipboard

OBSV-443 messagebird/pushprom does not respect log-level argument

Open sshilko opened this issue 3 years ago • 2 comments

The problem

Pushprom 1.0.8 is too verbose on default INFO level.

Trying to use the “documented” -log-level argument for the application does not have effect.

Update from 1.0.7 to 1.0.8 resulting in thousands unnecessary log records polluting the INFO logs.

Definition of Done

Pushprom 1.0.8 does not change behaviour when updating from 1.0.7 for logging.

or Pushprom 1.0.8 default verbosity level changes to “warn” and/or respect the -log-level documented argument.

https://github.com/messagebird/pushprom/tree/1.0.8

sshilko avatar Dec 02 '22 12:12 sshilko

I will submit the MR with the fix myself :)

sshilko avatar Dec 02 '22 17:12 sshilko

Please review https://github.com/messagebird/pushprom/pull/33

Behaviour change:

  • UDP listener now listens with timeout of 1 second, inside infinite loop, previously no timeout causes inifinite block.
  • HTTP listener write & read-header timeouts of 10 seconds, previously no timeouts
  • Log messages are now split between STDERR and STDOUT, previously all "log" messages went to STDERR
  • Previously HTTP& UDP servers were never gracefully shutdown, now they react to SIGINT, SIGTERM (no SIGQUIT)

sshilko avatar Dec 05 '22 14:12 sshilko