meshtastic
added SNR lines for neighborInfo and direct routes in map
Initial implementation of SNR route lines (see https://github.com/meshtastic/web/issues/456 for discussion)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Jamon Terrell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
I wanted to better understand where I would see the lines being drawn, I cloned your branch and opened it up. I didn't see anything connecting avatars on the Map, am I looking in the wrong place?
Directly attached nodes will be drawn immediately so long as your node has it's location set and you've heard from them recently.
Connections between other nodes are drawn when you see a NeighborInfo packet from them, but keep in mind that not all nodes have that turned on, and the node doesn't retain that information, so you'll only see the ones that come in while the client is connected.
We will be able to add traceroutes as a source of data in the future as well.
So some of the other app leads had a chat about this change and its awesome to see this contribution, but the new lines on the Map will need to be behind an option users can turn on and off inside the Map instead of simply applying to everyone. I think our mapping lib has an option to enable a layers selector, so this option should be added there.
yeah, they're already in a separate layer, so it should be pretty easy to enable/disable them. The bigger thing I think will be adding UI to allow filtering on the map--there's no filter ui at all now. It'd probably be helpful to have a few other options in there as well
- show/hide MQTT nodes
- show/hide direct connection signal lines
- show/hide indirect signal lines
It also looks like there might be some bugs in the display of the shortname on the map. Not sure if it's specific to me or not, but when you don't have node info, I'm seeing the first 4 of the mac instead of the last 4.
@jamon If you want to revisit this I believe the recent changes with map filters provide an interface to add display controls.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| web-test | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 12, 2025 1:48am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
updated with a toggle button and using filtered nodelist instead of all nodes for lines.
Nice!
I think we should include the SNR/display options in the filter popover. Alternatively, add another button with the SettingsIcon next to or above the existing filter button to open a separate popover with display settings.
Maybe something like this? The FilterControl component allows passing children that end up below the "reset filters" button.
This would allow us to add further display options in the future, such as position precision circles. I don't necessarily think this should stop a merge, it can be changed when more UI settings are added.
ah, crap. I accidentally caused this to close by renaming my branch to match the upstream change. restored it and attempting to reopen the request...
@philon- if you'd like to take a stab at making the UX nicer and resubmitting the PR, I'd be 100% good with that.