rust icon indicating copy to clipboard operation
rust copied to clipboard

Code Hygiene Job + Misc clippy fixes.

Open canardleteer opened this issue 1 year ago • 1 comments

Was pulling in the project locally, and noticed some lints failing. Trued those up in a way that I figured was reasonable, added a code hygiene job and refreshed the Actions a bit to reduce the warnings.

canardleteer avatar May 09 '24 04:05 canardleteer

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 09 '24 04:05 CLAassistant

Looks good! I'm struggling to push the merge conflict fix, it's just keeping both #[allow(dead_code)] and #[cfg(feature = "bluetooth-le")] in a few places.

ajmcquilkin avatar Sep 29 '24 18:09 ajmcquilkin

I have been swamped since I added this back in May. Will take a look at what's going on with the latest conflicts, and will try to get it back into shape on main.

canardleteer avatar Sep 29 '24 23:09 canardleteer

Rebased, and now passing new tests. Didn't bother checking to see if it was prost, clippy or the protobuf files that changed to cause the new clippy error, but at the end of the day I don't care and it's silenced surgically to prevent issues going forward.

canardleteer avatar Sep 30 '24 00:09 canardleteer