python icon indicating copy to clipboard operation
python copied to clipboard

Add "(MQTT)" in nodes after node name when appropriate

Open lachesis opened this issue 1 year ago • 2 comments

This matches what the Android app does.

lachesis avatar Oct 19 '24 05:10 lachesis

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 19 '24 05:10 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 19 '24 05:10 CLAassistant

I'm sorry to get to this so slowly. I don't like modifying the name that's returned; while that works for the apps, I think we should retain the values from the node. That being said, once https://github.com/meshtastic/python/pull/736 is merged, it should be possible to tell the CLI to add another column for the via-MQTT flag, which I think is ultimately better. I'm going to close this for now, and hopefully that other PR can be suitable to merge soon.

ianmcorvidae avatar Feb 18 '25 16:02 ianmcorvidae