firmware
firmware copied to clipboard
[Bug]: Serial Module TEXTMSG mode allows the sending of blank messages and non-ASCII chars
Category
Serial
Hardware
Other
Is this bug report about any UI component firmware like InkHUD or Meshtatic UI (MUI)?
- [ ] Meshtastic UI aka MUI colorTFT
- [ ] InkHUD ePaper
- [ ] OLED slide UI on any display
Firmware Version
2.5.20.4c97351
Description
Board is the Xiao ESP32S3 + Wio Lora.
With the serial module enabled in TEXTMSG mode and using the Linux Screen app as a terminal, pressing the ENTER key sends a blank message.
When plugging the USB cable into the (3.3V) USB to serial TTL adapter, it will sometimes generate spurious, non-ASCII character noise (probably unavoidable), which is also sent.
Suggestions:
- The serial module shouldn't allow blank messages (CR or CRLF only) to be sent.
- Maybe strip leading spaces before checking for blank messages?
- The serial module should not allow the sending of non-ASCII characters, except BEL and maybe some other important ones, if there are any.
Relevant log output