firmware icon indicating copy to clipboard operation
firmware copied to clipboard

🐞 [Bug]: Node Name Updates Don't Reflect in App without Restarting

Open Xaositek opened this issue 1 year ago • 3 comments

Firmware Version

2.5.18 (1355)

What did you do?

I changed the "Owner" name is a node and noticed even after multiple hours the application doesn't reflect the update in my node list.

Old Name: Image

New Name: Image

Expected Behavior

As NodeInfo updates are received by the radio, name updates are immediately reflected in the app

Current Behavior

As NodeInfo updates are received by the radio, name updates are only updated if you force close the app and restart it.

Participation

  • [ ] I am willing to submit a pull request for this issue.

Additional comments

No response

Code of Conduct

  • [x] I agree to follow this project's Code of Conduct

Xaositek avatar Feb 13 '25 18:02 Xaositek

@Xaositek what happens if you disconnect / reconnect BLE? I'm wondering if I need to send the owner info back up over the PhoneAPI

thebentern avatar Feb 13 '25 18:02 thebentern

Confirmed a BLE disconnect / reconnect also works to fix it

Xaositek avatar Feb 13 '25 18:02 Xaositek

Also noticed owner short name experiences the same issue

Xaositek avatar Feb 13 '25 18:02 Xaositek

@Xaositek what happens if you disconnect / reconnect BLE? I'm wondering if I need to send the owner info back up over the PhoneAPI

With firmware v2.5.20 (and I'm sure earlier as well) nodes automatically reboot after a name change which would trigger a Bluetooth disconnect/reconnect. Did this change in a more recent firmware?

madeofstown avatar Feb 20 '25 14:02 madeofstown

Also, there are known issues with v2.5.18 and the router_late role

madeofstown avatar Feb 20 '25 14:02 madeofstown

@Xaositek what happens if you disconnect / reconnect BLE? I'm wondering if I need to send the owner info back up over the PhoneAPI

With firmware v2.5.20 (and I'm sure earlier as well) nodes automatically reboot after a name change which would trigger a Bluetooth disconnect/reconnect. Did this change in a more recent firmware?

This is not about the directly connected node, this is about nodes in the node list

Xaositek avatar Feb 20 '25 14:02 Xaositek

@Xaositek what happens if you disconnect / reconnect BLE? I'm wondering if I need to send the owner info back up over the PhoneAPI

With firmware v2.5.20 (and I'm sure earlier as well) nodes automatically reboot after a name change which would trigger a Bluetooth disconnect/reconnect. Did this change in a more recent firmware?

This is not about the directly connected node, this is about nodes in the node list

A change of a nodes name should still trigger a reboot whether it is connected to your phone or remotely administered or administered by somebody else... When a node boots up it should send out it's node information. I guess I'm missing something here...

I just tested this with a remotely administered node and it did TX it's new node name. Remote node was v2.5.12. RX node is v2.5.20. Android app version 2.5.17. I can do more testing this evening.

I'm wondering if this bug report needs to go in the iOS-app repo.

madeofstown avatar Feb 20 '25 20:02 madeofstown

@garthvh If you look at the attached screenshots you will notice.

Screenshot 1 (System Time: 4:52pm, Last Node Info: 4:48pm) - Shown Device Name is "Meshenger 4e91" and Actual Device Name is "Meshenger 4e91"

Screenshot 2 (System Time: 4:54pm, Last Node Info: 4:53pm) - Shown Device Name is "Meshenger 4e91" and Actual Device Name is "Meshenger 001"

Screenshot 2 (System Time: 4:54pm, Last Node Info: 4:54pm) - AFTER BLE DISCONNECT/RECONNECT - Shown Device Name is "Meshenger 001" and Actual Device Name is "Meshenger 001"

Logs are present showing node info received at 4:53pm: DEBUG | 16:53:38 244338 [Router] handleReceived(REMOTE) (id=0xcd12d362 fr=0x2f224e91 to=0xffffffff, WantAck=0, HopLim=7 Ch=0x0 Portnum=4 rxtime=1741902818 rxSNR=7 rxRSSI=-20 hopStart=7 relay= DEBUG | 16:53:38 244338 [Router] Module 'nodeinfo' wantsPacket=1 INFO | 16:53:38 244338 [Router] Received nodeinfo from=0x2f224e91, id=0xcd12d362, portnum=4, payloadlen=76

Xaositek avatar Mar 13 '25 22:03 Xaositek

https://github.com/user-attachments/assets/fa511b70-9264-42e3-a82e-0d814f4e0c28 Adding a video also - I reverted the name back to showcase it. The name was changed around 5pm local time, here's it at 6pm. BLE disconnect/reconnect updated the name.

Xaositek avatar Mar 13 '25 23:03 Xaositek