ATAK-Plugin icon indicating copy to clipboard operation
ATAK-Plugin copied to clipboard

[Feature Request] Team colors for TAK Tracker nodes

Open habr05 opened this issue 1 year ago • 25 comments

Is there anything that prevents team color being applied to Tak Tracker nodes?

habr05 avatar May 26 '24 17:05 habr05

I think this should work already? Just append the node color scheme to the end of the long name.

See here for more details https://github.com/meshtastic/ATAK-Plugin/releases/tag/1.0.13

niccellular avatar May 29 '24 23:05 niccellular

it works for every type except "TAK TRACKER"

habr05 avatar May 29 '24 23:05 habr05

Both, "CTmA 6924 -5" and "TARDY", are the same node. The node is configured as "TAK_TRACKER".

Screenshot 2024-05-29 174805

habr05 avatar May 29 '24 23:05 habr05

I just tested this and it's working for me?

niccellular avatar Jun 05 '24 23:06 niccellular

Make sure you have "Show all Meshtastic devices" enabled

niccellular avatar Jun 07 '24 13:06 niccellular

So you're saying that team color, for TAK_TRACKER node type, will show only when "Show all Meshtastic devices" is enabled. Is that correct?

habr05 avatar Jun 07 '24 15:06 habr05

So you're saying that team color, for TAK_TRACKER node type, will show only when "Show all Meshtastic devices" is enabled. Is that correct?

Yes

niccellular avatar Jun 09 '24 15:06 niccellular

What's the reasoning behind it? Why not keep it consistent regardless of the "Show all Meshtastic devices" settings?

habr05 avatar Jun 13 '24 05:06 habr05

tracker nodes are meshtastic devices

niccellular avatar Jun 25 '24 00:06 niccellular

ATAK has a standalone "tracking only" app used for anything that does not have (require) user input. TAK_TRACKER would be equivalent of that app. In real life that would be useful to slap those trackers on equipment, team members or even as beacons for landing pad, medic, command post etc.

Just to make sure that we are talking about the same thing I'm including the screenshot of the selected option.

Screenshot_20240624_185952_Meshtastic

habr05 avatar Jun 25 '24 01:06 habr05

if you set a meshtastic device's role to tak_tracker/tracker, it is equiv the same when your eud enables show all meshtastic devices.

niccellular avatar Jun 25 '24 15:06 niccellular

the problem is that when I enable "show all..." the team color is applied to the node BUT if I disable "show all..." it is not and the appended -# shows in the name.

habr05 avatar Jun 25 '24 16:06 habr05

try using the "TRACKER" role not "TAK_TRACKER" i probably have a bug somewhere if what you are saying is correct. I'll try to fix it soon, but if you can try just using TRACKER role maybe it will get you going for now

niccellular avatar Jun 29 '24 14:06 niccellular

This is the issue I have experienced for some time. You're right that it only affects the TAK TRACKER role and that using the standard TRACKER role corrects the problem. The only thing I can find that might relate is the statement before checking colours in the long name. Checks if "plugin_meshtastic_tracker" is FALSE. Does this mean it is intentionally excluding the TAK TRACKER role?

https://github.com/meshtastic/ATAK-Plugin/blob/e0423ac2e826601a9d9781895e12c847b7427921/app/src/main/java/com/atakmap/android/meshtastic/MeshtasticReceiver.java#L354

alexsh5 avatar Jul 08 '24 20:07 alexsh5

Its getting the value of plugin_meshtastic_tracker if it is not set then the default is false

To use the role-by-name thing, you must have that preference enabled

niccellular avatar Jul 29 '24 13:07 niccellular

For context, the reason that this does not work on TAK TRACKER is because the information arrives from those nodes in a tak packet format and already includes a team color, which is hardcoded in the firmware. I put in a feature request for this to be added to the firmware

RichieFrame avatar Sep 20 '24 04:09 RichieFrame

https://github.com/meshtastic/firmware/discussions/4787 I guess we vote on feature requests now? If you want this, vote for it at the above link

RichieFrame avatar Sep 23 '24 05:09 RichieFrame

meshtastic/firmware#4787 I guess we vote on feature requests now? If you want this, vote for it at the above link

voted

habr05 avatar Sep 25 '24 16:09 habr05

I have test firmware running on my t-echo which lets me set the team color on demand from the device UI, which is one step closer to making the color a device config option so it can survive a reboot/shutdown, but its usable right now

I also added a build time override for the default color, maybe I can get this into the firmware with a little more work

Image Image Image

RichieFrame avatar Sep 25 '25 05:09 RichieFrame

I have test firmware running on my t-echo which lets me set the team color on demand from the device UI, which is one step closer to making the color a device config option so it can survive a reboot/shutdown, but its usable right now

I also added a build time override for the default color, maybe I can get this into the firmware with a little more work

Image Image Image

this is amazing! please create the necessary PRs for frmware and base UI. Just have it gated under the TAK TRACKER role. you will make a lot of people very happy

niccellular avatar Sep 25 '25 16:09 niccellular

As part of the experiment phase I was looking into the 'node type' data, it is not part of the CoT message from the node but rather hard coded in the plugin.

I am working on the member role menu now, but it would be nice if the type could be moved into the protobufs and CoT and out of the plugin, letting us set the node to things like:

Ground / Radio / Relay Ground / Vehicle / Automobile Air / Rotary wing / Drone etc

RichieFrame avatar Sep 26 '25 01:09 RichieFrame

yeah Ben and I have discussed having the Type also be dynamic.

niccellular avatar Sep 26 '25 14:09 niccellular

@RichieFrame This looks awesome 😎 any chance we will see this in a pre-release anytime soon?

stigf avatar Oct 13 '25 18:10 stigf

As part of the experiment phase I was looking into the 'node type' data, it is not part of the CoT message from the node but rather hard coded in the plugin.

I am working on the member role menu now, but it would be nice if the type could be moved into the protobufs and CoT and out of the plugin, letting us set the node to things like:

Ground / Radio / Relay Ground / Vehicle / Automobile Air / Rotary wing / Drone etc

Any chance you will be submitting a PR for the improvements? Also see you had this awhile ago, https://github.com/meshtastic/firmware/discussions/4787 I'm sure ben would be happy to help you get your changes into the code.

niccellular avatar Oct 20 '25 22:10 niccellular