Enhancement: Using Discovery API to discover Kubernetes Resources
Description To discover all resources in a cluster, this PR uses the Discovery API to list all resources and avoid hardcoding the resources to track and also supports using both whitelist and blacklisted resources in watch-list ConfigMap This PR fixes #274
Notes for Reviewers
Signed commits
- [x] Yes, I signed my commits.
Codecov Report
Attention: Patch coverage is 80.32787% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 11.95%. Comparing base (
a8e2fb7) to head (927e036). Report is 29 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| internal/config/default_config.go | 77.55% | 7 Missing and 4 partials :warning: |
| internal/config/crd_config.go | 91.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 9.37% 11.95% +2.58%
==========================================
Files 10 11 +1
Lines 651 669 +18
==========================================
+ Hits 61 80 +19
+ Misses 583 582 -1
Partials 7 7
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 11.95% <80.32%> (+2.58%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This might be an ideal time for a set of standard tests to be run. What sort of CI coverage do we have currently? Only compilation of golang, but no functional or integration tests, right?
Time to invest in one, I suggest. We already have a number of them that can be reused from meshery/meshery....
This might be an ideal time for a set of standard tests to be run. What sort of CI coverage do we have currently? Only compilation of golang, but no functional or integration tests, right?
Time to invest in one, I suggest. We already have a number of them that can be reused from meshery/meshery....
There are many of them, I shall have fun reusing some of them here
@VihasMakwana, your 👀s on this would be great.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
merge conflicts, @KiptoonKipkurui
@leecalcote @VihasMakwana @MUzairS15 I have resolved all conflicts and reviews
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.