meshkit icon indicating copy to clipboard operation
meshkit copied to clipboard

New return types to RegisterEnity and New errror codes

Open Jougan-0 opened this issue 1 year ago • 6 comments

Description

This PR fixes #

Notes for Reviewers New return types added so that can verify if the Registry error was because of model or registrant for the particular entity Few new error codes too.

Signed commits

  • [x] Yes, I signed my commits.

Jougan-0 avatar Mar 26 '24 22:03 Jougan-0

@Yashsharma1911 @MUzairS15 please review here the old pr was causing issue with the release

Jougan-0 avatar Mar 26 '24 22:03 Jougan-0

@Jougan-0 will you address the failed lint checks?

leecalcote avatar Mar 27 '24 04:03 leecalcote

@Jougan-0 provide a more description PR title, please.

leecalcote avatar Mar 27 '24 04:03 leecalcote

@Jougan-0 will you address the failed lint checks?

It's now my code error i guess becuase other pr have the linting error as well . If you want me to look why the linting error is caused I'll am looking into it . Currently I am studying the CKA and models so that I can create a proposal for the Gsoc issue .

Jougan-0 avatar Mar 27 '24 07:03 Jougan-0

https://github.com/meshery/meshery/pull/10567

Jougan-0 avatar Mar 27 '24 07:03 Jougan-0

@Jougan-0 Let's discuss this in Meshery dev call today. Add this as an agenda item to the meeting minutes, if you would :)

vishalvivekm avatar Mar 27 '24 07:03 vishalvivekm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 25 '24 10:05 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Jun 05 '24 01:06 stale[bot]