Move MeshModel to Model.

[gyohuangxin]

Description

This PR fixes #467

Notes for Reviewers

Signed commits

• [ ] Yes, I signed my commits.

[welcome[bot]]

Yay, your first pull request! :thumbsup: A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

[gyohuangxin]

@leecalcote Do you have any comments?

[leecalcote]

@leecalcote Do you have any comments?

Thank you for asking. I only have two:

1. Is regarding a potential existing bug in the namspacing of the MesheryAnnotationPrefix, which might need to be addressed in Meshery Server as well.
2. Which leads us to my second comment, which is: @MUzairS15 what do we need to do in order to ensure that Server and the mesheryctl registry command and workflows, and the meshery/schemas are all in sync as we move forward with what will be a series of changes? Is there a specific sequence of next steps to follow? @gyohuangxin, I'm trying to remember where it is that I proposed what this sequence might be. Do you recall, by chance?

[gyohuangxin]

Which leads us to my second comment, which is: @MUzairS15 what do we need to do in order to ensure that Server and the mesheryctl registry command and workflows, and the meshery/schemas are all in sync as we move forward with what will be a series of changes? Is there a specific sequence of next steps to follow? @gyohuangxin, I'm trying to remember where it is that I proposed what this sequence might be. Do you recall, by chance?

IMO, the dependencies sequence should be meshkit <- meshery-adapter-library <- Meshery components (Adapters, Mesheryctl... )

In order to make the transformation seamlessly, we can create a release of meshkit, then validate the meshery-adapter-library can work if update the meshkit version. Then we can create the release of meshery-adapter-library to validate other Meshery components base on that. This is a process that requires care and patience. @MUzairS15 Please correct me if I missed something.

[leecalcote]

Here's a related / similar chore - https://github.com/meshery/meshery/issues/9969

[leecalcote]

Which leads us to my second comment, which is: @MUzairS15 what do we need to do in order to ensure that Server and the mesheryctl registry command and workflows, and the meshery/schemas are all in sync as we move forward with what will be a series of changes? Is there a specific sequence of next steps to follow? @gyohuangxin, I'm trying to remember where it is that I proposed what this sequence might be. Do you recall, by chance?

IMO, the dependencies sequence should be meshkit <- meshery-adapter-library <- Meshery components (Adapters, Mesheryctl... )

In order to make the transformation seamlessly, we can create a release of meshkit, then validate the meshery-adapter-library can work if update the meshkit version. Then we can create the release of meshery-adapter-library to validate other Meshery components base on that. This is a process that requires care and patience. @MUzairS15 Please correct me if I missed something.

This is making sense to me, @gyohuangxin. @MUzairS15, sound about right?

[MUzairS15]

@gyohuangxin Yes, its correct. AdapterLibrary - adapters Meshery Server, mesheryctl.

While adapter-library and server can be done in parallel.

[MUzairS15]

While design.meshery.io change will affect UI clients.

I propose the change for this to be done, when the first iteration of the refactoring from meshmodels to models is complete.

I'll create a issue to track this item.

[MUzairS15]

@gyohuangxin Since meshkit undergoes a release often, and merging the PR would block subsequent releases and upgrades.

Will you first start the migration in Meshery Server by using this branch as local go.mod reference? When the server PR is up we can merge both of them.

[gyohuangxin]

@gyohuangxin Since meshkit undergoes a release often, and merging the PR would block subsequent releases and upgrades.

Will you first start the migration in Meshery Server by using this branch as local go.mod reference? When the server PR is up we can merge both of them.

@MUzairS15 Got it. Will work on that.

[leecalcote]

Uh-oh. A merge conflict popped up.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.