meshery
Enhance/system config eks/#2842/#165
Description
This PR fixes #165
Notes for Reviewers
Signed commits
- [ ] Yes, I signed my commits.
Hey @Zanda256 let's discuss this on the meshery dev call.
Sure, I'm available.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@Zanda256 @hexxdump are we still looking to fix the EKS issue or is this already resolved in other PR?
@alphaX86 , the implementation we had was working just fine, at least for the part of writing the EKS config to the local file, but then POSTing that context to the /api/system/kubernetes endpoint was failing here. So subsquent calls to kubectl would still use the old config.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
bump...
Can anyone provide some details on this PR?
Yes sure. This pr is meant do make a function that eliminates depency of the system config eks command on the aws cli. So the user can still execute the command even if they do not have the aws cli installed. We do huddle and go over any details. @acald-creator if you want to pick it up.