Grab ability range from wiki

Open and-zheng opened this issue 2 years ago • 3 comments

Abilities are only tracking target range right now, which directional casted abilities don't have. Added a line to grab ability range from the wiki. Consider making target range the same as cast range for directional casted abilities?

Aug 17 '23 03:08 and-zheng

Hi, you may want to add this to the champion model file too : ) https://github.com/meraki-analytics/lolstaticdata/blob/5843dd585c4f0c5fa0fa94ae97b912931f472314/lolstaticdata/champions/modelchampion.py#L163

Oct 10 '23 19:10 DarkIntaqt

Hey @and-zheng, can you please add the range to the Ability class as well? Without it, the code will break.

Oct 13 '23 01:10 jjmaldonis

Just did, thanks for the notice.

Jan 03 '24 01:01 and-zheng