Missing Item Shop Tag "ABILITY_HASTE"

Open tsworc opened this issue 1 year ago • 2 comments

Discovered this issue when running py -m lolstaticdata.items upon reaching the item "Experimental Hexplate". It looks like there's a new shop tag for ability haste (I guess because hexplate gives ultimate haste but not ability haste so it wasn't showing up in player's searches for haste?) Error occurs in "pull_items_wiki.py" in the code tags.append(ItemAttributes.from_string(tag)) My quick fix was adding ABILITY_HASTE = "ABILITY_HASTE" to the ItemAttributes enums in "modelitem.py".

Jan 11 '25 19:01 tsworc

Fixed it for me. should make a PR if this doesnt get picked up

Jan 20 '25 05:01 Galvantua

Made a PR with this fix in it: https://github.com/meraki-analytics/lolstaticdata/pull/108

Jan 26 '25 06:01 Galvantua