sudo-rs icon indicating copy to clipboard operation
sudo-rs copied to clipboard

use `std::os::unix::fs::fchown`

Open japaric opened this issue 2 years ago • 3 comments

instead of the unsafe libc::fchown. this API will be stabilized in Rust 1.73 (~ 2023-10-05)

https://github.com/memorysafety/sudo-rs/blob/9b9a7e428240930d213723ca39be16752c7d5e02/src/system/file/chown.rs#L16

japaric avatar Sep 05 '23 12:09 japaric

I would suggest we only do this once our MSRV increases past this version some time in the future, and not increase our MSRV just because of this feature.

rnijveld avatar Sep 05 '23 12:09 rnijveld

Maybe we can introduce some labels for issues that have to wait only because of a MSRV-related issue?

squell avatar Sep 05 '23 13:09 squell

@squell maybe we could do milestones for these so we can actually track the specific version for each issue, what do you think?

pvdrz avatar Sep 06 '23 04:09 pvdrz