nanosvg icon indicating copy to clipboard operation
nanosvg copied to clipboard

fix build using Watcom

Open sezero opened this issue 5 years ago • 8 comments

sezero avatar Mar 20 '21 15:03 sezero

PING?

sezero avatar Mar 30 '21 22:03 sezero

Dear sezero, THank you for your contribution. This is appreciated.

AFAIK only bugfixes are accepted to nanosvg. I suppose you should clearly state why your proposed change is a bugfix, as this is not obvious (for me).

And it would not harm to be a bit friendly.

Thank you again, Harald

oehhar avatar Mar 31 '21 07:03 oehhar

Don't take it from the wrong side. I would love to have this change in, as I also use a non C99 compatible compiler (MS-VC6). But this is not in the scope of the project.

Thank you, Harald

oehhar avatar Mar 31 '21 07:03 oehhar

This is for making nanosvg to compile using OpenWatcom: It doesn't accept non-const array initializers or declarations after statements.

If this is not acceptable, feel free to close this.

sezero avatar Mar 31 '21 07:03 sezero

And it would not harm to be a bit friendly.

I wasn't aware that I was unfriendly.

sezero avatar Mar 31 '21 07:03 sezero

Ozkan, sorry, I am not the maintainer. I just try to help to get this in. So explaining why you want that would help. Thats all.

And beeing friendly is on the level, that the programmer gave this gem for free and probably has invested monthes of his spare time. So starting with "thank you for the great software" would eventually be appropriate.

Thank you, Harald

oehhar avatar Mar 31 '21 07:03 oehhar

PING?

sezero avatar Jun 06 '21 15:06 sezero

PING? This is just a trivial C89-compatibility patch..

sezero avatar May 25 '22 16:05 sezero