SDF icon indicating copy to clipboard operation
SDF copied to clipboard

Subtle inconsistency?

Open fohly opened this issue 6 years ago • 1 comments

Line 290 in sdf.h compares tdist[kn] to tdist[k], while all other similar blocks compare it to pd. See https://github.com/memononen/SDF/blob/1ef5b4e4feb60ea84e47c01425de3edcf39bd83c/src/sdf.h#L290

Is this a mistake or is there a reason behind this? Although I think that this doesn't make much of a difference.

fohly avatar May 14 '19 08:05 fohly

You're right, it should be pd. There are some cases which do not work well, i wonder if this is the problem.

ti 14. toukok. 2019 klo 11.27 fohly [email protected] kirjoitti:

Line 290 in sdf.h compares tdist[kn] to tdist[k], while all other similar blocks compare it to pd. See https://github.com/memononen/SDF/blob/1ef5b4e4feb60ea84e47c01425de3edcf39bd83c/src/sdf.h#L290

Is this a mistake or is there a reason behind this? Although I think that this doesn't make much of a difference.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/memononen/SDF/issues/4?email_source=notifications&email_token=ABIBXSBIGZXNBN2DOQULI4DPVJZWBA5CNFSM4HMXPTW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GTTQD5A, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIBXSBEGJTCGOVMEJ6BOETPVJZWBANCNFSM4HMXPTWQ .

memononen avatar May 14 '19 11:05 memononen