memgraph
[master < T243-MAGE] Add logging API
[master < Task] PR
- [x] Add tests
- [x] Check, and update documentation if necessary
- [x] Update changelog
Once PR is ready, I will update the changelog and docs.
Please also considering adding tests, at least calling all of the functions to make sure it works.
I will add tests, immediately after we reach the decision on whether the PyLogger object is necessary.
It looks good to me to be merged, however I don't want to approve until at least the PR is created on the docs repo, but nothing more is left in my opinion.
For the formatter don't worry, sooner or later they would have been formatted, so you don't need to revert them.
It looks good to me to be merged, however I don't want to approve until at least the PR is created on the docs repo, but nothing more is left in my opinion.
@antaljanosbenjamin I've created a PR for docs, you can check it out here.
@antoniofilipovic It would be great if added comments to code matches to mgp.py previous style (there are some parts that I need to update), but you can use this function/class as reference: https://github.com/memgraph/memgraph/blob/T243-MAGE-add-logging-api/include/mgp.py#L756
