Maja Kądziołka
Maja Kądziołka
> I'd be a little concerned about an "off by one" invariant: it feels like a bug waiting to happen, or at the very least, a source of confusion when...
"rename LibVideo to LibVideo"?
Hi, sorry for taking a while to get back to you. In the following example, the output of `cargo expand` has 3 occurrences of `stream_position`, always assigned to an entirely...
> A lot of projects use one main crate to organize all crates that all crates in workspace may use. Wouldn't it be easier to use [Cargo's support for workspace...
@ozaner Just noticed your commits referencing this issue. I find your crate to be a compelling usecase for fixing this, though I don't think the solution currently being proposed would...
I do agree that the impl isn't ideal – the usecase is using `BitFlags` as (part of) a `BTreeMap` key, which unfortunately requires full `Ord`, and precludes any meaningful interpretations...
Is this guided by the output of any particular linter? Also, CI fails on the MSRV run.
I have decided that the changes here range from barely any improvement, though meaningless, to actively making the code harder to read, and that it isn't worth my time to...
You need to enable the `std` feature on `enumflags2`. Though, good point, this is not entirely discoverable, and perhaps the feature should be enabled by default.
Marking this as breaking change, as enabling the `std` feature by default would require action from everyone who's using the library on `#![no_std]`