meilisearch-java icon indicating copy to clipboard operation
meilisearch-java copied to clipboard

Update generic exception `MeilisearchException` to throw more accurate Exception

Open 239yash opened this issue 1 year ago • 3 comments

Pull Request

Related issue

Fixes #678

What does this PR do?

  • PR updates the generic exception(MeilisearchException) throws from function to exact exception throws
  • Created a new exception MeilisearchUrlException for handling MalformedUrlException

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

239yash avatar Mar 28 '24 21:03 239yash

Hi @curquiza Yes, I will add the integration tests too. Thanks

239yash avatar Mar 30 '24 18:03 239yash

@239yash did you have a chance to work on it?

curquiza avatar May 06 '24 14:05 curquiza

@curquiza hi, I am working on this. I will submit the PR by coming weekend. Thanks

239yash avatar May 07 '24 03:05 239yash

Closing this for lack of activity. Feel free to re-open of course if you have time to work on it @239yash ❤️ I'm just doing some cleaning

curquiza avatar Oct 03 '24 13:10 curquiza