guerrilla

guerrilla copied to clipboard

patch* functions should be marked unsafe

9

Setting aside the question of whether the patching routine itself should be considered safe, these functions can be used to break invariants, which makes them unsafe.

lemmabit

One patch! macro to rule them all

1

Currently there's the `patch*` functions which accept from 0 to 9 arguments, which is a limitation when it comes to a larger amount, which is surely non-idiomatic and not practical...

kotauskas

Thread safety?

1

Hello, first of all, I am really amazed by this crate! But I am not able to understand, what is really going on under the hood to achieve this functionality....

Gerschtli

test case for out-of-order drop

2

Demonstrates issue #6

kazcw

Code following very small functions can trampled by jumps

3

This is very much a duplicate of #3, but it seems like you had problems consistently reproducing the problem in tests. I put together a proof of concept which (at...

ftilde

when guards are dropped out of order the original function is never restored

2

This is inherent to the API, as there's no reasonable interpretation of what version to "restore" in such a case; so it might just be one for the "no monkey...

kazcw

So I've tried to use the lib on my machine, using minimal example from your test suite, namely ## src/main.rs ```rust fn main() { println!("Hello, world!"); } #[cfg(test)] #[inline(never)] fn...

mike-code

phlax