Ryan Leckey comments

Results 206 comments of


                                            Ryan Leckey

One scheduled function stops others from running

@glennpierce This is by design at the moment mostly because it's very simple. I'm glad you got it working. I'm planning on circling back to this at some point in...

Decorator support

Blocked until `#[proc_macro_attribute]` stablizes

Evaluate using Failure for error handling

Consider using https://github.com/dtolnay/anyhow which provides *only* `failure::Error` and some sugar around that. It also supports `no_std`.

test case for out-of-order drop

Thanks for writing up a test for this. Perhaps a keyed `ReentrantMutex` from `parking_lot` could be an answer?

when guards are dropped out of order the original function is never restored

We should probably at least use a mutex keyed to the target function address.

Thread safety?

Its doable. Just a great deal of work so not sure when I will get to it. I do want to do this.

One patch! macro to rule them all

I don't disagree here. I'd be willing to accept a PR that did this.

patch* functions should be marked unsafe

Fair. It'll make it slightly more annoying to use in tests but it's better to call this kind of hankey panky out. I'll accept a PR or I'll get to...

patch* functions should be marked unsafe

@Permutatrix Do you mind writing a small example to demonstrate an invariant being broken I can add to documentation? I can't think of something concrete.

patch* functions should be marked unsafe

Thinking back on this I've changed my mind. Regarding your example, rust `unsafe` vs safe doesn't cover logical behavior. If I change the behavior as demonstrated in your example its...