check icon indicating copy to clipboard operation
check copied to clipboard
verified publisher icon meedan

Redis HealthCheck - "FIXME"

Open Better-Boy opened this issue 5 years ago • 2 comments

Which service(s) is this report about? Let us know which services(s) this report is about:

  • Alegre

Description: # FIXME Redis database is not being tested by info() - https://github.com/meedan/alegre/blob/develop/app/main/controller/healthcheck_controller.py#L44

Currently, in health check in redis, more than needed information is fetched from the redis using r.info() which is not used anywhere in the healthcheck code.

Better-Boy avatar Oct 19 '20 19:10 Better-Boy

I have fixed this with explanation in the PR https://github.com/meedan/alegre/pull/36

Better-Boy avatar Oct 19 '20 19:10 Better-Boy

@computermacgyver This issue is fixed with the PR merged yesterday in the alegre repository. Can this issue be closed with the tags hacktoberfest and the component as alegre?

Better-Boy avatar Nov 01 '20 00:11 Better-Boy