admin icon indicating copy to clipboard operation
admin copied to clipboard

feat: Revamp RMA modals

Open kasperkristensen opened this issue 3 years ago • 6 comments

What

  • Updates all RMA modals to use react-hook-form, and their subcomponents.
  • Adds the latest version @tanstack/react-table and uses it for table implementations in the RMA modals.
  • Fixes bug where custom shipping prices were not added to RMA actions.
  • Fixes bug where trying to receive a return on a swap would throw an error due to missing tax_lines.
  • Improves how prices incl. tax is calculated for additional items, as the previous implementation was a bit naive and could result in the wrong prices being shown if a store has special taxes for some product types etc.
  • Brings RMA modal UI more in line with current admin design.

Why

  • Current implementation had several issues, as explained in the comments of CORE-569. This PR ensures that the behavior of RMA modals is stable, refactors code for the domain, and adds better typing to the domain.

kasperkristensen avatar Sep 27 '22 15:09 kasperkristensen

⚠️ No Changeset found

Latest commit: 3fead7469181344883b985f6bd8d61d4ad33b51f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 27 '22 15:09 changeset-bot[bot]

Deploy Preview for nostalgic-booth-1cf149 ready!

Name Link
Latest commit 3fead7469181344883b985f6bd8d61d4ad33b51f
Latest deploy log https://app.netlify.com/sites/nostalgic-booth-1cf149/deploys/633497714c09ab0009e696ba
Deploy Preview https://deploy-preview-709--nostalgic-booth-1cf149.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 27 '22 15:09 netlify[bot]

Deploy Preview for tekla-admin ready!

Name Link
Latest commit 3fead7469181344883b985f6bd8d61d4ad33b51f
Latest deploy log https://app.netlify.com/sites/tekla-admin/deploys/6334977106ba31000adf8687
Deploy Preview https://deploy-preview-709--tekla-admin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 27 '22 15:09 netlify[bot]

Deploy Preview for elastic-keller-bcaedb ready!

Name Link
Latest commit 3fead7469181344883b985f6bd8d61d4ad33b51f
Latest deploy log https://app.netlify.com/sites/elastic-keller-bcaedb/deploys/633497713e65690008001bf9
Deploy Preview https://deploy-preview-709--elastic-keller-bcaedb.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 27 '22 15:09 netlify[bot]

Deploy Preview for preeminent-gingersnap-0af4e1 ready!

Name Link
Latest commit 3fead7469181344883b985f6bd8d61d4ad33b51f
Latest deploy log https://app.netlify.com/sites/preeminent-gingersnap-0af4e1/deploys/6334977106ba31000adf868b
Deploy Preview https://deploy-preview-709--preeminent-gingersnap-0af4e1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 27 '22 15:09 netlify[bot]

Deploy Preview for playful-shortbread-286e24 ready!

Name Link
Latest commit 3fead7469181344883b985f6bd8d61d4ad33b51f
Latest deploy log https://app.netlify.com/sites/playful-shortbread-286e24/deploys/633497713e65690008001bfe
Deploy Preview https://deploy-preview-709--playful-shortbread-286e24.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 27 '22 15:09 netlify[bot]