admin icon indicating copy to clipboard operation
admin copied to clipboard

chore: Move VariantGrid to templates

Open djgovani opened this issue 3 years ago • 5 comments

What

  • Component which is used but not grouped according to the components structure of the folder

How

  • Move components/variant-grid to templates
  • Update imports

Closes https://github.com/medusajs/admin/issues/576

djgovani avatar Jun 19 '22 15:06 djgovani

Deploy Preview for nostalgic-booth-1cf149 ready!

Name Link
Latest commit 9c4e1647fd91281c147c8ad91e2631dc78e5196b
Latest deploy log https://app.netlify.com/sites/nostalgic-booth-1cf149/deploys/62af449f3d1c630008cfd2f1
Deploy Preview https://deploy-preview-606--nostalgic-booth-1cf149.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 19 '22 15:06 netlify[bot]

Deploy Preview for elastic-keller-bcaedb ready!

Name Link
Latest commit 9c4e1647fd91281c147c8ad91e2631dc78e5196b
Latest deploy log https://app.netlify.com/sites/elastic-keller-bcaedb/deploys/62af449f651ae700088d233c
Deploy Preview https://deploy-preview-606--elastic-keller-bcaedb.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 19 '22 15:06 netlify[bot]

Deploy Preview for preeminent-gingersnap-0af4e1 ready!

Name Link
Latest commit 9c4e1647fd91281c147c8ad91e2631dc78e5196b
Latest deploy log https://app.netlify.com/sites/preeminent-gingersnap-0af4e1/deploys/62af449f37bbe80009424038
Deploy Preview https://deploy-preview-606--preeminent-gingersnap-0af4e1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 19 '22 15:06 netlify[bot]

Deploy Preview for tekla-admin ready!

Name Link
Latest commit 9c4e1647fd91281c147c8ad91e2631dc78e5196b
Latest deploy log https://app.netlify.com/sites/tekla-admin/deploys/62af449fa850a200096d23f7
Deploy Preview https://deploy-preview-606--tekla-admin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 19 '22 15:06 netlify[bot]

Deploy Preview for playful-shortbread-286e24 ready!

Name Link
Latest commit 9c4e1647fd91281c147c8ad91e2631dc78e5196b
Latest deploy log https://app.netlify.com/sites/playful-shortbread-286e24/deploys/62af449f154011000895f00e
Deploy Preview https://deploy-preview-606--playful-shortbread-286e24.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 19 '22 15:06 netlify[bot]

Hi @djgovani,

Thank you for your contribution, and sorry for the time to respond.

The VariantGrid is being removed in an upcoming release, so I will be closing this PR as it is no longer needed.

kasperkristensen avatar Sep 05 '22 13:09 kasperkristensen

Hi @kasperkristensen thank you for responding. Can you please close the issue https://github.com/medusajs/admin/issues/576?

Also https://github.com/medusajs/admin/issues/575 and https://github.com/medusajs/admin/issues/574 will be there or removed in upcoming releases? If It'll be there I can move those folder as mentioned.

djgovani avatar Sep 05 '22 13:09 djgovani

@djgovani It will be closed automatically when the PR that deletes the VariantGrid is merged 😄

No those components still need to be moved, so you are more than welcome to open a new PR that resolves those particular issues.

kasperkristensen avatar Sep 05 '22 13:09 kasperkristensen

@kasperkristensen got it. I have opened a PR for both the issues to move components to atoms.

djgovani avatar Sep 06 '22 05:09 djgovani