goodreads-api-client-python icon indicating copy to clipboard operation
goodreads-api-client-python copied to clipboard

Bug #12 fix

Open teusday opened this issue 8 years ago • 4 comments

A fix to issue #12 by updating default base_url to https

teusday avatar Jan 21 '18 16:01 teusday

~~It appears the tests are failing on Travis because the dev key is still defaulting to fuubar~~

EDIT: My mistake.

teusday avatar Jan 21 '18 16:01 teusday

Hi @teusday! Thanks for your PR. The failures aren't due to the key but b/c the cassettes need to be updated for the HTTPS change http://goodreads-api-client.readthedocs.io/en/latest/contributing.html#updating-tests

mdzhang avatar Jan 21 '18 20:01 mdzhang

I regen'd them on my side and most tests are fixed save for goodreads_api_client.tests.resources.test_recommendation.TestRecommendation which I'd need to look into more to fully grok

EDIT: Pushed https://github.com/mdzhang/goodreads-api-client-python/commit/29e4ca229567515620911ae2dfdcaac3714b612f to help w/ the oauth recommendation endpoints

mdzhang avatar Jan 21 '18 20:01 mdzhang

Thanks for the response/clarified instructions. I did regen them, and had the same issue with Recommendation.

I poked around at it and can get the Recommendation class to work on the REPL, but it looks like recommendation needs OAuth, while the test expects it to work like all the other resources.

I regen'd the tests on the master branch and it gave me the same error; perhaps they've changed the endpoint's spec.

teusday avatar Jan 31 '18 20:01 teusday