python-mock-firestore icon indicating copy to clipboard operation
python-mock-firestore copied to clipboard

Support filter keyword in where clauses. (#74)

Open thromer opened this issue 1 year ago • 8 comments

FieldFilter support only, not composite filters.

thromer avatar Apr 13 '24 22:04 thromer

Tests pass locally, including a new test that exercises the filter keyword argument to Collection.where and Query.where.

thromer avatar Apr 13 '24 23:04 thromer

This looks good, @mdowds any chance this could be merged?

eddie avatar Jun 21 '24 16:06 eddie

Is there any plan to merge this code and release a new version

ritesh-researchify-labs avatar Jun 27 '24 10:06 ritesh-researchify-labs

Any status on this PR? Would be really nice to get this merged so this package works with modern .where() syntax.

ckanaar avatar Aug 01 '24 12:08 ckanaar

Any updates on this?! Can this be merged and create a new release for the package?

mohammadkotb avatar Aug 28 '24 04:08 mohammadkotb

I have some local changes based of this PR that also implements compound queries, if I have time next week I'll fork this and make it available until this repo becomes active again.

eddie avatar Aug 28 '24 14:08 eddie

Thanks @eddie that would be great! For now I cloned the repo to my code and made the code changes and depending on it as a package.

Let me know if you'd like to fork it and publish it as a package, I can collaborate and help, I see the value in this.

mohammadkotb avatar Aug 30 '24 17:08 mohammadkotb

I have forked the repo, added @thromer 's changes and also initial compound query support, please test as its a bit crude! Hopefully we can get this merged back into the main repo in time. Thanks all.

https://github.com/eddie/python-mock-firestore

https://pypi.org/project/mock-firestore-plus/0.12.0/

eddie avatar Sep 05 '24 11:09 eddie