pyoptsparse icon indicating copy to clipboard operation
pyoptsparse copied to clipboard
verified publisher icon mdolab

Update types

Open ewu63 opened this issue 2 months ago • 2 comments

Purpose

Just some long-overdue type annotations

Expected time until merged

A few days

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [x] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [x] I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [x] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation

ewu63 avatar Nov 16 '25 22:11 ewu63

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 86.63%. Comparing base (c9c8c9d) to head (a58a117).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   86.69%   86.63%   -0.07%     
==========================================
  Files          24       24              
  Lines        3464     3463       -1     
==========================================
- Hits         3003     3000       -3     
- Misses        461      463       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 16 '25 22:11 codecov[bot]

The error on readthedocs must be a glitch (setuptools missing from the environment?) because the other PRs are not having the same issue.

The stable build is failing because that image is still using python<3.10, so there is a version conflict. Let me try real quick to move back the requirement to see if at least the RTD build passes

marcomangano avatar Dec 12 '25 17:12 marcomangano