adflow icon indicating copy to clipboard operation
adflow copied to clipboard

Antisymmetry BC with surface-piercing topology

Open gawng opened this issue 2 years ago • 1 comments

Purpose

This needs more test cases before it is ready for merging.

The antisymmetry BC is appropriate for high-speed foils near the free surface for modelling the loss of lift and increase in drag. This PR contains the antisymmetry option that works for surface-piercing topology (e.g., a strut).

Expected time until merged

Summer 2024

Type of change

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (non-backwards-compatible fix or feature)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no API changes)
  • [ ] Documentation update
  • [ ] Maintenance update
  • [ ] Other (please describe)

Testing

Checklist

  • [ ] I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • [ ] I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • [ ] I have run unit and regression tests which pass locally with my changes
  • [ ] I have added new tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation

gawng avatar Jun 09 '23 02:06 gawng

Codecov Report

Merging #287 (6525adb) into main (ab4323d) will decrease coverage by 13.75%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #287       +/-   ##
===========================================
- Coverage   41.98%   28.24%   -13.75%     
===========================================
  Files          13       13               
  Lines        4001     4001               
===========================================
- Hits         1680     1130      -550     
- Misses       2321     2871      +550     

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 09 '23 02:06 codecov[bot]