OpenAeroStruct icon indicating copy to clipboard operation
OpenAeroStruct copied to clipboard

Change the driver used in the tests to pyOptSparse

Open sabakhshi opened this issue 1 year ago • 5 comments

Description of feature

Several of the existing tests use the SciPy driver rather than the pyOptSparse one. This was due to the limitations of the existing test environment. Now that we are moving OAS to Azure we should change the drivers to pyOptSparse.

Potential solution

Change the test drivers to pyOptSparse(either IPOPT or SLSQP) when moving to Azure.

sabakhshi avatar Jul 18 '24 21:07 sabakhshi

Going to tag @A-CGray since he's the one moving OAS to Azure.

sabakhshi avatar Jul 18 '24 21:07 sabakhshi

Why can't we keep using the scipy driver for testing? I know we can now use pyoptsparse easily but what's the point of switching the driver?

kanekosh avatar Jul 18 '24 22:07 kanekosh

Yeah I think I would need to hear a pretty compelling reason to motivate the effort of moving all our tests over. Scipy SLSQP is probably the common optimizer people use with OAS (even if pyoptsparse is better) so I think it makes sense that we want to primarily test against that.

A-CGray avatar Jul 18 '24 23:07 A-CGray

When I met with @lamkina he mentioned that pyOptSparse was the most common driver used by OpenMDAO users and that we should be testing with that. Do you have anything to add to that Andrew?

sabakhshi avatar Jul 19 '24 16:07 sabakhshi

I think it should be tested with both the pyOptSparse and Scipy drivers. I've heard several people complain about issues with SLSQP and many OpenMDAO users are interfacing with the pyOptSparse driver. IPOPT is open source and with the advent of the meson build in pyOptSparse it's built during the installation. I don't really see barriers to adding simple tests for both drivers.

lamkina avatar Jul 19 '24 16:07 lamkina