js-examples icon indicating copy to clipboard operation
js-examples copied to clipboard

Top Level Await examples do not have await code

Open xkeshav opened this issue 1 year ago • 4 comments

under the top level await example folder, the code in main.js file is similar to dynamic module imports example folder main.js file content,

There is no example of usage of await syntax.

Cheke this file

https://github.com/mdn/js-examples/blob/main/module-examples%2Ftop-level-await%2Fmain.js

this code is similar to the previous example (dynamic module import) file

https://github.com/mdn/js-examples/blob/main/module-examples%2Fdynamic-module-imports%2Fmain.js

xkeshav avatar Feb 28 '24 19:02 xkeshav

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

github-actions[bot] avatar Feb 28 '24 19:02 github-actions[bot]

Hey, I would love to work on this issue, can you assign me!?

Chay2203 avatar Mar 02 '24 06:03 Chay2203

Hey, This has been fixed by me already.

xkeshav avatar Mar 04 '24 02:03 xkeshav

Ohh great @xkeshav!

Chay2203 avatar Mar 04 '24 03:03 Chay2203

Closing this one, see the linked PR for details. Thank you :)

bsmth avatar Jul 10 '24 09:07 bsmth