Toxiproxy.Net icon indicating copy to clipboard operation
Toxiproxy.Net copied to clipboard

Plans to use netstandard or .NET Core

Open joaoasrosa opened this issue 7 years ago • 12 comments

Hi, Great work here! :)

There are any plans to support .NET Core, or at least be netstandard?

From a quick scan in the repo, the JSON dependency needs to be updated

Cheers

joaoasrosa avatar Jul 24 '18 17:07 joaoasrosa

Thanks,

I'm afraid to say that I don't do any .NET or C# in my day job so have let this project and my knowledge of the .NET world slip a bit. I do however have half an eye on whats going on but am pretty time poor at the moment.

I would love a PR if you had time ;-)

Thanks again,

Mark

mdevilliers avatar Jul 26 '18 07:07 mdevilliers

Might be interested in picking this up, just started using ToxiProxy and will need the .NET client. Looks fairly straight forward.

https://icanhasdot.net/result?github=mdevilliers~2FToxiproxy.Net

josephwoodward avatar Nov 28 '18 08:11 josephwoodward

I have a work in progress pull request of migrating this to .NET Standard

josephwoodward avatar Nov 29 '18 14:11 josephwoodward

Hey @JosephWoodward Thanks for picking this up. If I can be of any help of assistance please shout! (My email is in my profile)

Mark

mdevilliers avatar Dec 05 '18 18:12 mdevilliers

Thanks @mdevilliers, it's getting there.

All the tests are now passing on my Mac. I've had to bundle the Windows, Mac and Linux builds of the ToxiProxy server. Still a little bit more to go.

josephwoodward avatar Dec 11 '18 20:12 josephwoodward

Whats the latest on this port? I could do with a netcore version of this. I'm happy to look at doing my own port if this PR has aborted.

matt-richardson avatar Sep 18 '19 23:09 matt-richardson

@matt-richardson It hasn't been aborted, it's almost done - I just haven't been able to commit much time to it lately. Would love some help to get it over the line though?

josephwoodward avatar Sep 19 '19 04:09 josephwoodward

Happy to help (though for the next couple of weeks I’m a bit time poor). What’s outstanding?

matt-richardson avatar Sep 19 '19 04:09 matt-richardson

The work in progress PR is here, I can't remember exactly where I got up to with it. I think the next step was to launch the appropriate toxi server executable based on the runtime (I'll have to refresh my memory)

josephwoodward avatar Sep 19 '19 04:09 josephwoodward

@mdevilliers from what I see @JosephWoodward PR is ready to be accepted, no? even if tests won't work out of Windows it should be enough for now. Sorry, we really need this library for a .net core 3 project, would be awesome if you could put some time in publishing the new .net standard version.

Thanks, great work BTW

adospace avatar Oct 11 '19 21:10 adospace

For those interested I've recompiled the library to work in .net standard ( https://github.com/adospace/toxiproxy-netcore)

adospace avatar Oct 31 '19 16:10 adospace

@mdevilliers is this repo still maintained? I would like to maintain and upgrade this to .net 7.0. Using the upgrade based on @adospace derived repo

zeotuan avatar May 22 '23 05:05 zeotuan