perfect-scrollbar
perfect-scrollbar copied to clipboard
Corrected shouldBeConsumedByChild logic for vertical scrolling
Fixes mdbootstrap/perfect-scrollbar#139
Thank you very much for your contribution! Please make sure the followings are checked.
- [x] Read CONTRIBUTING.md
- [x] Run
npm testto make sure it formats and build successfully - [x] Provide the scenario this PR will address(some JSFiddles will be perfect)
- addressed in tagged issue
- [x] Refer to concerning issues if exist
Description
Because deltaY is negative when the user is scrolling down, the logic in shouldBeConsumedByChild for vertical scrolling was flawed.
The solution was simply adjusting the > / < operators to match the deltaY values.
@filipkappa @marveluck @mdbootstrap any feedback or ETA for this being integrated?