SharpLearning icon indicating copy to clipboard operation
SharpLearning copied to clipboard

SharpLearning.XGBoost.dll is not compatible with .net core

Open festith opened this issue 5 years ago • 6 comments

Hi, SharpLearning.XGBoost.dll is not compatible with .net core due to PicNet.XGBoost (0.2.1) dependency. Checked on 0.31.8 version. And Core 2.1 version Do you plan to fix it?

festith avatar Sep 11 '20 12:09 festith

Hi @festith, Currently PicNet.XGBoost is the handling the interop with XGBoost, so the quickest route to having this fixed is probably to open an issue in XGBoost.Net and have them update the package to be compatible with .Net Core 2.1.

Longer term I might add my own wrapper for handling the interop with XGBoost. That way I can easilier make changes and add support for new features.

Best regards Mads

mdabros avatar Oct 11 '20 10:10 mdabros

@festith Seems a PR has already been made: https://github.com/PicNet/XGBoost.Net/pull/28 If it is merged I will update the package for Sharplearning, and that should provide support for .net core 2.1.

mdabros avatar Oct 11 '20 14:10 mdabros

@mdabros PicNet/XGBoost really appears to be abandonware - no updates since 2018 or any signs of live for getting up to date with netstandard2.0, or .Net Core 3.1+

fbraun4358 avatar May 21 '21 17:05 fbraun4358

@fbraun4358 I agree on that observation. Might be time for a new C# wrapper for XGBoost. I have been thinking of making one, but I have not had the time yet sadly.

mdabros avatar May 22 '21 17:05 mdabros

Hello, it took quite awhile, but it seems that my commit has just been merged. Although, it still stands that there's no real updates since 2018

coffeebenzene avatar May 27 '21 18:05 coffeebenzene

@coffeebenzene Sadly they did not publish a new nuget package it seems: https://www.nuget.org/packages/PicNet.XGBoost/

If I can get them to publish one, I will upgrade SharpLearning.

mdabros avatar Jun 07 '21 18:06 mdabros