Mike Crute
Mike Crute
Hi @jmhbnz, sure thing! I've added some tests for the functionality. Let me know if there's anything else needed to get this merged.
Thanks @jmhbnz, I appreciate it. Would really like to get this merged so let me know if there's anything I can do to help move it along. Have a nice...
Thanks for the review, I've rebased main under this so hopefully we'll get a green test run.
Looking at the failing test. I don't see how it's immediately related to this change but it's an auth test so I'm suspicious.
Found the issue. Unconditionally setting `authTokenBundle` to something non-nil breaks the no-auth tests. Revised to fix this.
Once this is merged I'll create a PR for the docs. I learned a ton digging through this functionality and definitely would like to make sure others can use it...
Have had some time constraints but I'll post an update soon. Adding validation + test case for credential mixes as well as an e2e test validating that standalone token auth...
@jmhbnz I'm planning to pick this back up this week, have been distracted by other priorities but would very much like to get this finished and merged.
@jmhbnz sorry for the delay on this but I've now added an e2e test for this functionality. Let me know if there's anything else needed to get this merged. Thanks!
Ping @serathius & @ahrtr. Do you have a moment to review (and hopefully merge) this PR? I think that it's complete and incorporates all of the feedback.