[1.17.1] Composite Fishing Rod fails

[Yirok42]

Operating System: Windows 10 version 10.0 Minecraft Version: 1.17.1 Java Version: 17.0.2, Oracle Corporation client-1.17.1-20210706.113038-srg forge-1.17.1-37.1.1-universal create-mc1.17.1_v0.4 flywheel-forge-1.17-0.3.0 gravestone-1.17.1-1.0.4 Futurepack-1.17.1-32.1.7175 journeymap-1.17.1-5.8.0 jei-1.17.1-8.3.1.62

Describe the bug When clicking to deploy the Composite Fishing Rod, it immediately is not deployed.

To Reproduce Steps to reproduce the behavior:

1. Research Composite Fishing Rod
2. Take the bonus rod out of the Researcher
3. Click to fish in the local river.
4. Repeat step 3 until you give up and make a Vanilla Fishing Rod

Screenshots N/A

Additional context The first time I ever had to watch the screen to catch my 4 needed Puffer fish. It was still enjoyable.

[mcenderdragon]

This need https://github.com/MinecraftForge/MinecraftForge/pull/8424 first.

[mcenderdragon]

ok so seems like we can finally work on this again: https://github.com/MinecraftForge/MinecraftForge/pull/8681 Edit: nope its 1.19 - so 1.18 will be forever broken thanks forge...

[eerussianguy]

https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/1.18.x/src/main/java/net/dries007/tfc/mixin/client/FishingHookRendererMixin.java

this mixin fixes the renderer

and you can fix the fishing hook just by subclassing, which is harmless

[mcenderdragon]

https://github.com/TerraFirmaCraft/TerraFirmaCraft/blob/1.18.x/src/main/java/net/dries007/tfc/mixin/client/FishingHookRendererMixin.java

this mixin fixes the renderer

and you can fix the fishing hook just by subclassing, which is harmless

subclass ic it is not workign as miencr5aft uses type checks and not instanceof checks, the fishing rod is already a subclass but it checks if its a vanilla fishing rod item not not accepting anything else

And mixing are jsut horrible and makes everythign ahrder tio read becuase the code you think is executed got changed.